Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: force (de)serialization to create params section incase there is none. #9574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

contrib: force (de)serialization to create params section incase there is none. #9574

wants to merge 1 commit into from
+68 −0

Conversation

0xFFFC0000
Copy link
Collaborator

No description provided.

This was referenced Nov 15, 2024
Closed
Closed
@0xFFFC0000 0xFFFC0000 force-pushed the dev/0xfffc/fix-serialization-empty-field-issue branch from c812753 to e9adafa Compare November 16, 2024 20:23
@vtnerd
Copy link
Contributor

vtnerd commented Nov 19, 2024

The other solution would be

KV_SERIALIZE_OPT(params, t_param{})

in jsonrpc_structs.h. That might be better from a maintenance standpoint, but it's somewhat of a toss-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnerd vtnerd vtnerd approved these changes

Assignees
No one assigned
Labels
easy important pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xFFFC0000 @vtnerd