Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Readme rewrite development guide #13

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

Jibola
Copy link
Collaborator

@Jibola Jibola commented Jan 8, 2024

No description provided.

@Jibola Jibola requested review from NoahStapp and a team January 8, 2024 19:13
@Jibola Jibola changed the title [Task]: Readme refactor development guide [Task]: Readme rewrite development guide Jan 8, 2024
Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording changes, otherwise good!

docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
@Jibola Jibola requested a review from NoahStapp January 9, 2024 18:09
Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor comments, otherwise great!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
@Jibola Jibola force-pushed the readme-refactor-development-guide branch from 13ce636 to b57f29e Compare January 9, 2024 20:33
@Jibola
Copy link
Collaborator Author

Jibola commented Jan 9, 2024

scoped changes in this PR to just development-guide.md From henceforth, #12 will contain the generalized readme changes

@Jibola Jibola requested a review from NoahStapp January 9, 2024 20:39
Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny wording change, otherwise good!

docs/development-guide.md Outdated Show resolved Hide resolved
Jibola added a commit to Jibola/full-stack-fastapi-mongodb that referenced this pull request Jan 9, 2024
docs/development-guide.md Outdated Show resolved Hide resolved
@Jibola Jibola requested a review from NoahStapp January 9, 2024 20:59
Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nitpick 😄

docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
@Jibola Jibola requested a review from NoahStapp January 10, 2024 15:12
@Jibola
Copy link
Collaborator Author

Jibola commented Jan 10, 2024

One final nitpick 😄

Thanks for all the re-reads, quite honestly. My only new change here is adding the example image.

Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency updates, then good to go! Awesome work thanks Jib

docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
docs/development-guide.md Outdated Show resolved Hide resolved
@Jibola Jibola requested a review from NoahStapp January 10, 2024 21:26
@Jibola Jibola merged commit 1f954d5 into mongodb-labs:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants