Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models are out of date with the new pydantic modeling paradigm from pydantic 2.0 #21

Closed
sammaphey opened this issue Jan 23, 2024 · 2 comments

Comments

@sammaphey
Copy link

Seems like this is still using the old implementation of Config for pydantic. For example:

class RefreshToken(RefreshTokenUpdate):
    class Config:
        from_attributes = True

Should now be re-written as:

from pydantic import ConfigDict

class RefreshToken(RefreshTokenUpdate):

    model_config = ConfigDict(from_attributes=True)

I believe you should be able to use Bump Pydantic to get a lot of these things fixed with minimal work

@Jibola
Copy link
Collaborator

Jibola commented Feb 5, 2024

Thanks for highlighting this issue @sammaphey.

We've gone ahead and captured this in a JIRA ticket, where you can track its' progress.

Feel free to open a PR related to the issue and we will happily review it any time.

@Jibola
Copy link
Collaborator

Jibola commented Feb 28, 2024

Marking issue as "fixed" with introduction of PR: #29

@Jibola Jibola closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants