CLOUDP-271909: fix deleted user struct #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Sep 9, 2024
husniMDB
force-pushed
the
CLOUDP-271909_fix_delete_user_struct
branch
from
9735743 to
281306c
Compare
gssbzn
reviewed
Sep 9, 2024
opsmngr/automation_config.go
Outdated
Comment on lines
236
to
237
| Username string `json:"user"` //nolint:tagliatelle // used as in the API | ||
| Databases []string `json:"dbs"` //nolint:tagliatelle // used as in the API |
There was a problem hiding this comment.
let's follow tagliatelle
Suggested change
| Username string `json:"user"` //nolint:tagliatelle // used as in the API | |
| Databases []string `json:"dbs"` //nolint:tagliatelle // used as in the API | |
| User string `json:"user"` | |
| DBs []string `json:"dbs"` |
There was a problem hiding this comment.
had to keep //nolint for dbs as it's not accepted this way and needs to be dBs
husniMDB
force-pushed
the
CLOUDP-271909_fix_delete_user_struct
branch
from
281306c to
248cd12
Compare
gssbzn
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-271909
Closes #239
Checklist
make fmtand formatted my codeFurther comments