Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using buf's protoc to get rid of C deps #110

Open
leoluk opened this issue Dec 21, 2022 · 4 comments
Open

Evaluate using buf's protoc to get rid of C deps #110

leoluk opened this issue Dec 21, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@leoluk
Copy link
Member

leoluk commented Dec 21, 2022

Much of the work done by Bazel during a clean NetMeta build is related to building protoc.

Perhaps we can use buf's pure-Go protoc instead? Probably a performance win, too.

@leoluk leoluk added the enhancement New feature or request label Dec 21, 2022
@leoluk
Copy link
Member Author

leoluk commented Jan 4, 2023

rules_proto comes with a prebuilt protoc toolchain: https://github.com/bazelbuild/rules_proto

We should be able to use that to avoid that step.

@fionera
Copy link
Collaborator

fionera commented Apr 17, 2023

I just tried buf for a different project and its fairly simple. I would prefer it over the prebuilt chain

@leoluk
Copy link
Member Author

leoluk commented Apr 17, 2023

With Bazel?

@leoluk
Copy link
Member Author

leoluk commented Apr 17, 2023

Tricky part is convincing rules_proto use the buf protoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants