Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Allow overriding of brand colors in flavours #155

Open
abias opened this issue Dec 4, 2022 · 2 comments · May be fixed by #346
Open

Improvement: Allow overriding of brand colors in flavours #155

abias opened this issue Dec 4, 2022 · 2 comments · May be fixed by #346
Assignees
@mwehr
Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@abias
Copy link
Member

abias commented Dec 4, 2022

This is a follow-up to #153:

In the first implementation of the flavours feature, it is not possible yet to override the brand color within a flavour.

It would be worthwhile to extend this in a way that also SCSS code can be used.
The challenge is to build this in a way that the brand color is properly compiled in the shipped CSS and that we do not end up with a blown up CSS result which just overrides all colors in every single selector from Boost Union's main SCSS.

To achieve this goal, a closer look at https://tracker.moodle.org/browse/MDL-65438 and https://github.com/bmbrands/theme_picture/compare/change_css_urls (which was the basis for a similar feature in Moodle workplace) should be the way to go.
@abias abias added the feature Something which is a new feature or big improvement label Dec 4, 2022
@mwehr
Copy link
Collaborator

mwehr commented Jul 11, 2023 •
edited
Loading

Hi,

Anyone working this?
If not I will start working on this.

regards
Mario

@abias
Copy link
Member Author

abias commented Jul 11, 2023

Hi @mwehr ,

I am not aware that anyone is working on this yet. I would really appreciate if you would have a look at it and will add you as assignee.

Don't hesitate to drop us a line if you have questions about the implementation details.

Cheers,
Alex

mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 18, 2023
@mwehr
moodle-an-hochschulen#155 Allow overriding of brand colors in flavours
0701f6c
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 18, 2023
@mwehr
moodle-an-hochschulen#155 Add support of SCSS in flavor raw scss
18f4675
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 18, 2023
@mwehr
moodle-an-hochschulen#155 Allow overwriting of brand colors in flavours
d85e164
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 18, 2023
@mwehr
moodle-an-hochschulen#155 Add support for SCSS in flavor raw scss
860471e
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 19, 2023
@mwehr
moodle-an-hochschulen#155 Added removing of flavour fallback sheet.
94a3eab
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 19, 2023
@mwehr
moodle-an-hochschulen#155 Cleanup no longer used files and functions.
c661d67
mwehr added a commit to mwehr/moodle-theme_boost_union that referenced this issue Jul 20, 2023
@mwehr
moodle-an-hochschulen#155 Added flavour SCSS validation.
832645f
@wiebkemueller-hsh wiebkemueller-hsh added improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) and removed feature Something which is a new feature or big improvement labels Oct 2, 2023
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 2, 2023
@abias abias moved this from In Progress DEV to Ready for REVIEW in Boost Union Planning Board Nov 2, 2023
@HsH-Wolf HsH-Wolf linked a pull request Jan 15, 2024 that will close this issue
#155 Allow overwriting of brand colors in flavours #346
Open
@abias abias moved this from Ready for REVIEW to Ready for TEST in Boost Union Planning Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwehr mwehr

Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Boost Union Planning Board
Status: Ready for FUNCTEST
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#155 Allow overwriting of brand colors in flavours mwehr/moodle-theme_boost_union
3 participants
@abias @mwehr @wiebkemueller-hsh