Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] project vs projectName in Query documentation #1053

Closed
shellscape opened this issue Sep 18, 2023 · 6 comments
Closed

[docs] project vs projectName in Query documentation #1053

shellscape opened this issue Sep 18, 2023 · 6 comments

Comments

@shellscape
Copy link

There's a funky ambiguation (is that a word?) between project and projectName on the Query language docs here: https://moonrepo.dev/docs/concepts/query-lang

Screenshot 2023-09-18 at 10 32 03 AM

I made the mistake of not navigating to the projectName section before trying to use it, and attempted projectName~svc-* because the fields list shows projectName. Turns out that it's not projectName but project.

I'd like to suggest that the list of fields and section header reflect the actual value that needs to be used. I'd wager that others will get bit by that as well.

@milesj
Copy link
Collaborator

milesj commented Sep 18, 2023

@shellscape project and projectName are supported fields, the latter is just more specific.

What about projectName~svc-* didn't work exactly? If that's the project name, it should work?

@shellscape
Copy link
Author

I had tried projectName but it caused the error below

moon run :deploy --query "projectName~svc-*" --affected --concurrency 1 --remote
Error: query::unknown_field

This was on moon 1.13.4

@milesj
Copy link
Collaborator

milesj commented Sep 18, 2023

@shellscape Ok that just looks like a bug, will fix.

@shellscape
Copy link
Author

ah cool. happy accident

@milesj
Copy link
Collaborator

milesj commented Sep 18, 2023

@shellscape Can you give 1.13.5 a shot

@shellscape
Copy link
Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants