corporate proxy functionality

[nmccready]

What version?

No response

Which command?

No response

What happened?

All http/s calls are blocked.

$ proto install go 1.20
Error: plugin::http

  × Failed to make HTTP request.
  ├─▶ error sending request for url (https://github.com/moonrepo/go-plugin/releases/latest/download/go_plugin.wasm): error trying to connect: invalid peer certificate: UnknownIssuer

Any logs?

No response

Operating system?

MacOS

Architecture?

x64

[nmccready]

Please refer to this thread TY oven-sh/bun#3917 (comment)

[milesj]

@nmccready Hrmm, is github overall blocked by your proxy? Does your company have custom certs that should be used (can maybe add a setting for this)?

I've never solved this kind of thing, but I'll look into it.

[milesj]

Tinkering here: #205

[milesj]

Added [http] in 0.18. Let me know if this works for you. I'll leave this open for now.

[nmccready]

@nmccready Hrmm, is github overall blocked by your proxy? Does your company have custom certs that should be used (can maybe add a setting for this)?

I've never solved this kind of thing, but I'll look into it.

No its not blocked, thanks for looking.

Added [http] in 0.18. Let me know if this works for you. I'll leave this open for now.

Will try to verify today.

[nmccready]

Something is still wonky

$ proto list-remote go
Error: plugin::http

  × Failed to make HTTP request.
  ├─▶ error sending request for url (https://github.com/moonrepo/go-plugin/releases/latest/download/
  │   go_plugin.wasm): error trying to connect: invalid peer certificate: UnknownIssuer
  ├─▶ error trying to connect: invalid peer certificate: UnknownIssuer
  ╰─▶ invalid peer certificate: UnknownIssuer


in ~
$ proto install go 1.19
Error: plugin::http

  × Failed to make HTTP request.
  ├─▶ error sending request for url (https://github.com/moonrepo/go-plugin/releases/latest/download/
  │   go_plugin.wasm): error trying to connect: invalid peer certificate: UnknownIssuer
  ├─▶ error trying to connect: invalid peer certificate: UnknownIssuer
  ╰─▶ invalid peer certificate: UnknownIssuer

Is there additional config needed for proto to pick up HTTP_PROXY, HTTPS_PROXY, http_proxy, and https_proxy?

[milesj]

What settings did you try? And can you include the --log trace output?

[nmccready]

Nothing fancy, HTTP(S?)_PROXY is exported in the shell session as well as the lower case version. Normally this is picked up by whatever proxy agent.

$ proto --log trace list-remote  go
[DEBUG 2023-09-18 14:18:51] proto  Running proto v0.18.0
[TRACE 14:18:51] starbase::app  Running startup phase with 1 systems
[TRACE 14:18:51] starbase::app  Running analyze phase with 1 systems
[TRACE 14:18:51] starbase::app  Running execute phase with 2 systems
[DEBUG 14:18:51] proto_core::tool_loader:list_remote  Traversing upwards to find a configured plugin  tool="go"
[TRACE 14:18:51] warpgate::loader:list_remote  Creating plugin loader  cache_dir="/Users/SOME_USER/.proto/plugins"
[TRACE 14:18:51] warpgate::loader:list_remote  Loading plugin go  plugin="go" locator="source:https://github.com/moonrepo/go-plugin/releases/latest/download/go_plugin.wasm"
[TRACE 14:18:51] warpgate::loader:list_remote  Plugin not cached, downloading  plugin="go"
[TRACE 14:18:51] warpgate::loader:list_remote  Downloading plugin from URL  plugin="go" from="https://github.com/moonrepo/go-plugin/releases/latest/download/go_plugin.wasm" to="/Users/SOME_USER/.proto/plugins/go-latest-ad1b059006b052b961a3af8e2f33b4c7fc2eabdb9f4fac3dbb6c6093b60405cb.wasm"
[TRACE 14:18:51] starbase::app  Running shutdown phase with 1 systems
Error: plugin::http

  × Failed to make HTTP request.
  ├─▶ error sending request for url (https://github.com/moonrepo/go-plugin/releases/latest/download/
  │   go_plugin.wasm): error trying to connect: invalid peer certificate: UnknownIssuer
  ├─▶ error trying to connect: invalid peer certificate: UnknownIssuer
  ╰─▶ invalid peer certificate: UnknownIssuer

[milesj]

According to the docs, the env vars should work (https://docs.rs/reqwest/0.11.20/reqwest/#proxies), so maybe something else is going on?

I can probably be explicit and do the implementation manually instead of relying on the lib.

[nmccready]

Seems similar. rustic-rs/rustic#679

[milesj]

Looks to be exactly the same, let me try that.

[milesj]

Ok, give 0.18.1 a shot.

[nmccready]

Works 🎆

[milesj]

Ahh hell yeah. Thanks for finding that thread!