Broken state after aborting an install command

[jakst]

What version?

0.19.1

Which command?

proto install

What happened?

I ran proto install pnpm 8.8.0, and then aborted the command half way through. After that the same command would get stuck in an endless installation whenever I ran it. The only thing that resolved the issue was blowing away the ~/.proto folder and reinstalling proto.

After reinstalling proto I intentionally tried to break proto again with proto install bun 1.0.3 and aborting, and managed to break it in the same way. So this seems reproducible with multiple tools.

Any logs?

No response

Operating system?

MacOS

Architecture?

Arm64

[milesj]

I'm not really sure what the fix would be here? Maybe a --force option for install?

The problem I'm guessing is that the directory is locked, because it was never unlocked.

[jakst]

Can you detect the lock on the subsequent install and prompt for a force? It might be hard for many users to realize they need to use the --force flag otherwise.

[milesj]

The waiting/hanging is because of the lock. If the lock exists, the program waits until the lock is removed.

Let me think about this a bit more. Maybes theres some kind of cleanup I can trigger when receiving a signal.

[jakst]

Is it possible to install to a temporary location, and then switch in the new binary as a last step? This would reduce the time you need to have a lock enabled

[milesj]

Trying this #226

[milesj]

Ok I think 0.19.2 should handle this

[jakst]

@milesj I think the new method has some problems. I keep getting this error message

Here's a link to the logs: https://pastebin.com/ryuaBZfS

[milesj]

@jakst When this happens, have you checked what's at ~/.proto/tools/pnpm/8.9.0?

[jakst]

Haven't checked the actual contents, but I tried clearing the folder and rerunning, without success. I can check

[milesj]

Yeah I'm curious what's actually there that's blocking it.

This isn't running in parallel with another process yeah?

[milesj]

Just going to delete it if it does exist: #230

[jakst]

Yeah I'm curious what's actually there that's blocking it.

This isn't running in parallel with another process yeah?

Sorry, I was doing other things and forgot to check, but now I by habit bumped to the fixed version before I had a chance to test it 😅

No parallell proto process was running.