Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: fedWireMessage is an object, not an array #358

Open
DennyWeinberg opened this issue Nov 30, 2023 · 7 comments · May be fixed by #394
Open

API: fedWireMessage is an object, not an array #358

DennyWeinberg opened this issue Nov 30, 2023 · 7 comments · May be fixed by #394
Labels
bug Something isn't working enhancement New feature or request

Comments

@DennyWeinberg
Copy link

WIRE Version

v0.15.0

What were you trying to do?

I'm creating, parsing and validating WIRE files that contains multiple transactions.

What did you expect to see?

A parsed JSON structure containing all my fed wire messages.

What did you see?

A parsed JSON structure containing ONLY the last fed wire message, others are lost.

The problem is, the API JSON is not a list: https://moov-io.github.io/wire/api/#post-/files/create

{
  "ID": "3f2d23ee214",
  "fedWireMessage": {
    "ID": "3f2d23ee214",
...

So how could that hold multiple messages? fedWireMessage should be an array, not an object.

How can we reproduce the problem?

  1. Call the create API with a WIRE file that contains multiple messages
  2. Check the response, only one message is returned obviously because it's not an array
@adamdecaf adamdecaf added bug Something isn't working enhancement New feature or request labels Nov 30, 2023
@adamdecaf
Copy link
Member

Yea.. We'll need to make this change. I think a breaking change is appropriate since this is such a major bug.

@atonks2
Copy link
Contributor

atonks2 commented Nov 30, 2023

Thanks @DennyWeinberg. I'll be addressing this one soon.

@DennyWeinberg
Copy link
Author

Any news here?

@atonks2
Copy link
Contributor

atonks2 commented Jan 6, 2024

I've been asking around for sample files to see how bulk/batch files should be formatted, but haven't been able to find anything.

I'll get back to researching this next week.

@Denny-g6labs
Copy link

Any news here? :)

@atonks2
Copy link
Contributor

atonks2 commented Apr 25, 2024

I haven't been able to find much info about how batch files should be formatted. Do you have any example files you can share @Denny-g6labs?

@atonks2 atonks2 linked a pull request May 6, 2024 that will close this issue
Open
@atonks2
Copy link
Contributor

atonks2 commented May 7, 2024

@Denny-g6labs If you have the ability to run some files through PR #394, any feedback would be appreciated. I'd love to hear how those changes handle files from various financial institutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple messages per file moov-io/wire
4 participants
@adamdecaf @DennyWeinberg @atonks2 @Denny-g6labs