Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When PNG has fewer colors than 255+1, consider force saving as palette image #122

Open
mosbth opened this issue Oct 20, 2015 · 0 comments
Open
Assignees
Milestone

Comments

@mosbth
Copy link
Owner

mosbth commented Oct 20, 2015

The following code was removed from load()

        /* Removed v0.7.7
        if (image_type_to_mime_type($this->fileType) == 'image/png') {
            $type = $this->getPngType();
            $hasFewColors = imagecolorstotal($this->image);

            if ($type == self::PNG_RGB_PALETTE || ($hasFewColors > 0 && $hasFewColors <= 256)) {
                if ($this->verbose) {
                    $this->log("Handle this image as a palette image.");
                }
                $this->palette = true;
            }
        }
        */

Consider to move it to save() instead.

@mosbth mosbth self-assigned this Oct 20, 2015
@mosbth mosbth added this to the v0.8 milestone Oct 20, 2015
@mosbth mosbth modified the milestones: v0.8.backlog, v0.8 Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant