Merge pull request #16813 from Ondsel-Development/core_placement_ui #1499
Annotations
7 errors and 23 warnings
Codespell
Process completed with exit code 2.
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
Cpplint
Process completed with exit code 2.
|
Clang-tidy:
src/Gui/Application.cpp#L76
'GuiInitScript.h' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/DlgAbout.cpp#L57
'ui_AboutApplication.h' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/MainWindow.cpp#L2521
'moc_MainWindow.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy
Process completed with exit code 1.
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/Application.cpp#L2286
QTimer::singleShot(0, &mw, SLOT(delayedStartup())); <--Consider using Functor-Based Connections
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/StartupProcess.cpp#L242
QObject::connect(qtApp, SIGNAL(messageReceived(const QList<QString> &)), <--Consider using Functor-Based Connections
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/StartupProcess.cpp#L243
mainWindow, SLOT(processMessages(const QList<QString> &))); <--Consider using Functor-Based Connections
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
Clang-tidy:
src/Gui/Application.cpp#L148
constructor does not initialize these fields: map [cppcoreguidelines-pro-type-member-init]
|
Clang-tidy:
src/Gui/Application.cpp#L156
do not use const_cast [cppcoreguidelines-pro-type-const-cast]
|
Clang-tidy:
src/Gui/Application.cpp#L164
do not use const_cast [cppcoreguidelines-pro-type-const-cast]
|
Clang-tidy:
src/Gui/Application.cpp#L186
class 'ApplicationP' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
Clang-tidy:
src/Gui/Application.cpp#L188
constructor does not initialize these fields: documents, passive [cppcoreguidelines-pro-type-member-init]
|
Clang-tidy:
src/Gui/Application.cpp#L222
32 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Gui/Application.cpp#L227
variable 'o' is not initialized [cppcoreguidelines-init-variables]
|
Clang-tidy:
src/Gui/Application.cpp#L227
variable name 'o' is too short, expected at least 2 characters [readability-identifier-length]
|
Clang-tidy:
src/Gui/Application.cpp#L228
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
Clang-tidy:
src/Gui/Application.cpp#L228
implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
|
Loading