Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec Impl] Add checksum to all writes #41

Open
krishnakumar4a4 opened this issue Jan 26, 2023 · 1 comment
Open

[Spec Impl] Add checksum to all writes #41

krishnakumar4a4 opened this issue Jan 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@krishnakumar4a4
Copy link
Contributor

krishnakumar4a4 commented Jan 26, 2023

Background

Every write from/to Wallet has a possibility to have corruption. Hence all writes should include a checksum at the last.

What to do

  1. Modify all the structures chunk write, transfer report request, transfer summary report to include checksum at the end.
  2. Finalise on the CRC to be used. The suggestion is to use CRC16-CCITT-True which is used in Bluetooth 5.3
  3. Update Transfer report structure to match with the specification. Also investigate if the mentioned structure is okay for a success and failure case. Since it will have CRC, on a success case, it will still have CRC value to differentiate between a success report Vs a spurious empty characteristic read.

References for finalising the CRC

https://reveng.sourceforge.io/crc-catalogue/16.htm

@krishnakumar4a4 krishnakumar4a4 added the enhancement New feature or request label Jan 26, 2023
@krishnakumar4a4 krishnakumar4a4 transferred this issue from mosip/inji-wallet Mar 17, 2023
@Pragya279
Copy link

This requirement has been moved to Jira.
Link to Jira ticket: https://mosip.atlassian.net/browse/MOSIP-26906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Development
Development

No branches or pull requests

3 participants