Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation discrepancy regarding supported Python versions #932

Closed
mkrausse-ggtx opened this issue Nov 28, 2023 · 6 comments
Closed

Documentation discrepancy regarding supported Python versions #932

mkrausse-ggtx opened this issue Nov 28, 2023 · 6 comments
Labels
bug Impact - something is currently broken in Parsons and needs to be fixed medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users

Comments

@mkrausse-ggtx
Copy link
Contributor

The README.md file says "Parsons is only supported for Python 3.8-10." However on PyPI it says "Requires: Python >=3.7.0, <3.11.0"

Not sure which is correct.

@mkrausse-ggtx mkrausse-ggtx added the bug Impact - something is currently broken in Parsons and needs to be fixed label Nov 28, 2023
@Jason94
Copy link
Collaborator

Jason94 commented Dec 5, 2023

Here is the code from setup.py. It looks like PyPi is correct. However, this brings up that it's high time we move on from Python 3.7. It was sunset from receiving security updates a little while ago, and even Python 3.8 only has 10 months left. (Source).

        classifiers=[
            "Development Status :: 3 - Alpha",
            "Intended Audience :: Developers",
            "Programming Language :: Python :: 3.7",
            "Programming Language :: Python :: 3.8",
            "Programming Language :: Python :: 3.9",
            "Programming Language :: Python :: 3.10",
        ],
        python_requires=">=3.7.0,<3.11.0",

@shaunagm Has there been conversation about bumping the Python version? In the meantime, I suppose we should fix the README?

@Jason94
Copy link
Collaborator

Jason94 commented Dec 5, 2023

I guess that allowing older versions isn't a problem. We should maybe consider adding 3.11, though. PETL (https://github.com/petl-developers/petl/blob/master/setup.py) still has Python 2.x listed as an allowed version! Although it does go up to 3.11.

I suppose the bigger issue with 3.7 is that it's still the Python version for the Dockerfile, but that's maybe a question for @willyraedy .

@shaunagm
Copy link
Collaborator

@willyraedy are you okay with us no longer officially supporting 3.7? Will changing it in the setup.py file cause any issues for your automatic builds etc?

Ideally TMC doesn't need 3.7 and we can solve this issue by adding 3.11 to the test suite, fixing any bugs that appear in the tests under 3.11, and then updating the documentation and setup.py to reflect that we now officially support 3.8-3.11.

If TMC wants to keep 3.7 listed we can. The only downside is if there are bugs that only occur when running parsons under 3.7, in which case we ought to handle them.

@shaunagm shaunagm added the medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users label Dec 19, 2023
@bmos
Copy link
Contributor

bmos commented Mar 14, 2024

Pytest does not pass on 3.7 so if that is supposed to be supported, it might not be.
https://github.com/move-coop/parsons/actions/runs/8274714031/job/22640505554

@jdw25
Copy link
Collaborator

jdw25 commented Jul 25, 2024

I think this is now resolved with release of 3.2.0?

@shaunagm
Copy link
Collaborator

Yes, correct! Thanks for the flag @jdw25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Impact - something is currently broken in Parsons and needs to be fixed medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users
Projects
None yet
Development

No branches or pull requests

5 participants