Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage reporting #1126

Closed
wants to merge 2 commits into from
Closed

Code coverage reporting #1126

wants to merge 2 commits into from

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Sep 6, 2024

Prompted by #1114 I created coverage testing.

The main thing about this that I don't like is that it reports on each version which is probably pointless? Does anyone know if that is worth doing or not?

@bmos bmos changed the title Cov Code coverage reporting Sep 6, 2024
@shaunagm
Copy link
Collaborator

shaunagm commented Sep 6, 2024

Each version of what? Python? Parsons?

@bmos
Copy link
Contributor Author

bmos commented Sep 6, 2024

Ah, sorry. Each version of Python and each testing platform.

@shaunagm
Copy link
Collaborator

shaunagm commented Sep 6, 2024

Yeah, feels like we should only have to run it once. It's not like the coverage would differ on those versions/platforms.

@bmos bmos marked this pull request as draft September 6, 2024 18:26
cache: pip
- name: Install uv
run: |
pip install uv

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 4: pipCommand not pinned by hash
Click Remediation section below to solve this issue
@@ -63,7 +63,7 @@
cache: pip
- name: Install uv
run: |
pip install -U pip uv
pip install uv

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium test

score is 4: pipCommand not pinned by hash
Click Remediation section below to solve this issue
cache: pip
- name: Install uv
run: |
pip install uv==0.4.6

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 4: pipCommand not pinned by hash Click Remediation section below to solve this issue
@@ -63,7 +63,7 @@
cache: pip
- name: Install uv
run: |
pip install -U pip uv
pip install uv==0.4.6

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 4: pipCommand not pinned by hash Click Remediation section below to solve this issue
@bmos bmos marked this pull request as ready for review September 6, 2024 19:05
@bmos
Copy link
Contributor Author

bmos commented Sep 7, 2024

Do we care about the pip install uv command not targeting a specific package hash?

@bmos bmos marked this pull request as draft September 7, 2024 12:49
@bmos bmos closed this Sep 7, 2024
@bmos bmos deleted the cov branch September 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants