Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newlines ignored (not converted to <br> tags) #6

Open
james-camilleri opened this issue Jul 11, 2021 · 2 comments
Open

Newlines ignored (not converted to <br> tags) #6

james-camilleri opened this issue Jul 11, 2021 · 2 comments

Comments

@james-camilleri
Copy link

I've noticed that newline characters are not converted to <br> tags in the final output. I've narrowed it down to ChildNodes.svelte component - there are explicit checks for string nodes and nodes with children - this excludes <br> tags which are not text nodes but do not have children. I've managed to correct the code so that it work sin my scenario, however I'm not sure if there are other edge cases that were encountered during the plugin's development that might be affected by this change.
@james-camilleri james-camilleri mentioned this issue Jul 11, 2021
Closed
@james-camilleri
Copy link
Author

Tentative fix in #7

@james-camilleri
Copy link
Author

Any hope of merging this, or shall I publish my own bundle and handle it myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@james-camilleri