New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach CoT verify about github-pull-request-untrusted `tasks_for` #563

Open

ahal opened this issue Oct 11, 2022 · 2 comments

Contributor

ahal commented Oct 11, 2022

This is a new value that's possible after:
https://phabricator.services.mozilla.com/D157493

Might be as simple as adding a second condition to this if statement:

scriptworker/src/scriptworker/cot/verify.py

Line 1315 in c711a7b

elif tasks_for == "github-pull-request":

Contributor

escapewindow commented Oct 11, 2022

Plausible, yes :) We may also want to adjust valid_tasks_for.

Contributor

escapewindow commented Oct 11, 2022

And is_pull_request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment