Patches fetched from local mercurial

[anubhabsen]

Issue #1506
I think this applies the patches from the local mercurial repository using a fetch. Please do let me know if there is something I am missing, and how I should go about testing it.

[marco-c]

This is a Phabricator revision ID, it's not the hash of the commit we just applied to the local mercurial repository.

[anubhabsen]

Sorry about that. If I understand correctly, needed_stack contains the list of patches to be applied. So path.base_revision where patch is an element of needed_stack is the hash of a commit that needs to be applied?

[marco-c]

No, base_revision is the revision in the Mercurial repository on top of which the patch must be applied (

bugbug/scripts/commit_classifier.py

Lines 278 to 282 in 78e5b5a

	# Update repo to base revision
	hg_base = needed_stack[0].base_revision
	if not self.has_revision(hg, hg_base):
	logger.warning("Missing base revision {} from Phabricator".format(hg_base))
	hg_base = "tip"

).

The process should be:

1. Get patches from Phabricator;
2. Apply each patch to the local Mercurial repository at the specified base revision;
3. Fetch the commits from the local Mercurial repository in the local git repository.

For 3, the commits come from the local Mercurial repository, Phabricator is already out of the picture.

[marco-c]

Closing for lack of updates, feel free to reopen if you still intend to work on this.