[WIP] Fetched local mercurial repo's commit hash #1560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 57.33% 57.24% -0.10%
==========================================
Files 107 107
Lines 9170 9185 +15
==========================================
Hits 5258 5258
- Misses 3912 3927 +15
Continue to review full report at Codecov.
|
scripts/commit_classifier.py
Outdated
| @@ -315,10 +315,12 @@ def load_user(phid): | |||
| revision["fields"]["title"], revision["fields"]["summary"] | |||
| ) | |||
|
|
|||
| latest_rev = repository.get_revs(hg, f"-{len(stack)}") | |||
There was a problem hiding this comment.
We haven't applied the patches yet here, so this will return wrong revisions.
There was a problem hiding this comment.
The code should moved after the end of the for loop.
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 108 108
Lines 9403 9403
=======================================
Hits 5374 5374
Misses 4029 4029
Continue to review full report at Codecov.
|
| @@ -377,6 +373,8 @@ def load_user(phid): | |||
| check=True, | |||
| cwd=self.git_repo_dir, | |||
| ) | |||
| latest_rev = repository.get_revs(hg, f"-{len(stack)}") | |||
There was a problem hiding this comment.
You're setting this variable here, but trying to use it earlier 😄
Maybe this is not an easy enough task to start with, I'd suggest working on some personal projects first to get some initial experience with programming.
closes #1506
I have currently only fetched the local mercurial repo's commit hash where the patches are applied, yet to apply that commit to the git repo and replace lines 358-380.
I hope I'm in the right direction :)