Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the input rate and the output rates are same if the stream is duplex #100

Open
ChunMinChang opened this issue Jul 17, 2020 · 0 comments

Comments

@ChunMinChang
Copy link
Member

The cubeb.c disallows to create a duplex stream with different input rates and output rates. However, it's ok to do so in this crate:

https://github.com/ChunMinChang/cubeb-coreaudio-rs/blob/dce7ddc846fb4784b4452f6eda282b67d286e27d/src/backend/tests/interfaces.rs#L487-L499

Aligning the policy here and the policy used in the main cubeb repo makes more sense and causes less confusion. Otherwise, the reader may have different assumptions when reading the code.

A good first step is to add an assertion when initializing the stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant