Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox crash when running cubeb-coreaudio-rs ./run_tests.sh #172

Open
padenot opened this issue Apr 12, 2022 · 1 comment
Open

Firefox crash when running cubeb-coreaudio-rs ./run_tests.sh #172

padenot opened this issue Apr 12, 2022 · 1 comment

Comments

@padenot
Copy link
Collaborator

padenot commented Apr 12, 2022

STR on an M1 Max (not sure if relevant):

  • Play audio in Firefox, using the Web Audio API (I was playing something on soundcloud)
  • Run the tests via the wrapper script: ./run_tests.sh

Expected:

  • It messes up the audio, because it changes the default audio output device a few times, etc.

Actual:

I think we need to stop putting in asserts like this, it's really annoying to crash on something like that. It's a lot better to simply rely on the system erroring out and this crate or Firefox dealing with the error.

@padenot
Copy link
Collaborator Author

padenot commented Apr 12, 2022

Might be the same fix as #171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant