Bug 1928168 - Disable the glean.database.write_time metric by default.

CHANGELOG.md

@@ -7,6 +7,7 @@
     Safe-mode became the default in Glean v51. ([bug 1780370](https://bugzilla.mozilla.org/show_bug.cgi?id=1780370))
   * **BREAKING**: Stop sending buckets with 0 counts in memory_distribution and timing_distribution metric payloads ([bug 1898336](https://bugzilla.mozilla.org/show_bug.cgi?id=1898336))
   * Require `glean_parser` v15.2.0 ([bug 1925346](https://bugzilla.mozilla.org/show_bug.cgi?id=1925346))
+  * Disabled the `glean.database.write_time` metric as the instrumented behavior was triggering metrics pings to be sent containing only that metric ([Bug 1928168](https://bugzilla.mozilla.org/show_bug.cgi?id=1928168))
 * Rust
   * New Metric Type: `labeled_quantity` ([bug 1925346](https://bugzilla.mozilla.org/show_bug.cgi?id=1925346))
 

glean-core/metrics.yaml

@@ -735,6 +735,7 @@ glean.database:
       - [email protected]
       - [email protected]
     expires: never
+    disabled: true
 
 glean.validation:
   foreground_count:

glean-core/rlb/tests/test-thread-crashing.sh

@@ -23,16 +23,14 @@ cargo run -p glean --example crashing-threads -- "$datapath"
 ret=$?
 count=$(ls -1q "$datapath/pending_pings" | wc -l)
 
-# We expect 2 pending pings:
-# - a metrics ping
-# - a prototype ping
-if [[ $ret -eq 0 ]] && [[ "$count" -eq 2 ]]; then
+# We expect 1 `prototype` ping:
+if [[ $ret -eq 0 ]] && [[ "$count" -eq 1 ]]; then
   echo "test result: ok."
   exit 0
 else
   echo "Assertions:"
   echo "  ret - expected: 0, was: $ret"
-  echo "  count - expected: 2, was: $count"
+  echo "  count - expected: 1, was: $count"
   echo "test result: FAILED."
   exit 101
 fi

glean-core/src/internal_metrics.rs

@@ -303,7 +303,7 @@ impl DatabaseMetrics {
                     category: "glean.database".into(),
                     send_in_pings: vec!["metrics".into()],
                     lifetime: Lifetime::Ping,
-                    disabled: false,
+                    disabled: true,
                     dynamic_label: None,
                 },
                 TimeUnit::Microsecond,

glean-core/tests/ping.rs

@@ -284,6 +284,7 @@ fn test_scheduled_pings_are_sent() {
 }
 
 #[test]
+#[ignore] // This metric is disabled by default now, so we can skip this test. See Bug 1928161
 fn database_write_timings_get_recorded() {
     let (mut glean, _t) = new_glean(None);