Small fixes to the iOS build #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytes" This reverts commit ad98555. This lint was reverted, due to the "new" way actually swalling errors.
|
Oh it actually doesn't fail, because CI uses swiftlint 0.53 which is so old, it doesn't have that (somewhat broken) new lint! |
Because I should have included the link: realm/SwiftLint#5263 (comment) tl;dr: the way we changed it to is swallowing errors, and thus swiftlint actually reversed the decision and lints AGAINST this now. |
travis79
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will actually likely currently fail on CI, because the
swiftlintwe use there is older?I have swiftlint 0.57 locally.
We might wanna update that check to Xcode 16 soon.