Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1929905 - docs: Use theme's variables to define tab colors #2994

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 11, 2024

This makes it look nice for the dark themes too

[doc only]


Currently for the Ayu theme:

image

New for the Ayu theme:

image

Navy:

image

And Coal:

image

This makes it look nice for the dark themes too

[doc only]
@badboy badboy requested a review from a team as a code owner November 11, 2024 16:03
@badboy badboy requested review from travis79 and removed request for a team November 11, 2024 16:03
@badboy badboy changed the title docs: Use theme's variables to define tab colors Bug 1929905 - docs: Use theme's variables to define tab colors Nov 11, 2024
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

@badboy badboy merged commit 9e41895 into main Nov 12, 2024
29 of 30 checks passed
@badboy badboy deleted the 1929905/better-tab-colors-in-darkmode branch November 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants