Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of exposure window without redefining the entire exposure signal #2038

Open
danielkberry opened this issue Apr 3, 2024 · 0 comments

Comments

@danielkberry
Copy link
Contributor

danielkberry commented Apr 3, 2024

The exposure window is, by default, the enrollment period. Sometimes this should be changed to another period. It should be easy for users to change the time window we look for exposures, without manually writing a new exposure signal.

Ideally, the following should work:

[experiment.exposure_signal]
window_start = 0
window_start = 14

Currently, this generates missing parameter errors. IMO, we should allow users to specify either 1) only these 2 fields or 2) all fields. In the case of 1, metric-config-parser should layer these fields on top of (and override) the defaults.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant