Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf_("%#.4o", 1) produces "00001", should produce "0001" #110

Open
eyalroz opened this issue Jul 14, 2021 · 0 comments
Open

printf_("%#.4o", 1) produces "00001", should produce "0001" #110

eyalroz opened this issue Jul 14, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Jul 14, 2021

According to cppreference.com, and as implemented in glibc, the alternative mode for %o must ensure at least one leading zero is printed - but it doesn't increase the precision if a leading zero is already printed. Thus,

printf_("%#.4o", 1)

must produce "0001", not "00001". And yet - the latter is produced.
eyalroz referenced this issue in eyalroz/printf Jul 14, 2021
Exposing bugs #75, #99, #109, #110 via the test suite.
9f3e2a7
eyalroz pushed a commit to eyalroz/printf that referenced this issue Jul 14, 2021
Exposing bugs mpaland#75, mpaland#99, mpaland#109, mpaland#110 via th…
3ed1199 
…e test suite.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
WIP - mpaland#109, mpaland#110
47b3f0e
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
WIP - mpaland#109, mpaland#110
3dfa0d3
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
056c5ed 
…n the octal format.
eyalroz pushed a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Exposing bugs mpaland#75, mpaland#99, mpaland#109, mpaland#110 via th…
0002294 
…e test suite.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
5ef00ab 
…n the octal format.
eyalroz pushed a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Exposing bugs mpaland#75, mpaland#99, mpaland#109, mpaland#110 via th…
29ee8bb 
…e test suite.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
e2479f2 
…n the octal format.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
876a309 
…n the octal format.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
0e4f087 
…n the octal format.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
4785fdc 
…n the octal format.
eyalroz referenced this issue in eyalroz/printf Jul 31, 2021
@eyalroz
Fixes #114; regards #109, #99, #110.
f4ad2ad 
* Added a couple of test cases for exposing the behavior of the `#` modifier (alternative mode) together with `ll` (long long modifier), and specifically exposing the example format string mentioned in bug #114.
* Our fix for #109 was too eager to keep `FLAG_HASH` - it dropped it only when a precision wasn't specified. We're now going part of the way back - dropping `FLAG_HASH` even when precision wasn't specific - except for octal.
* The `long long` version of ntoa now behaves just like the `long` version.
eyalroz referenced this issue in eyalroz/printf Jul 31, 2021
@eyalroz
Fixes #114; regards #109, #99, #110.
e178f4e 
* Added a couple of test cases for exposing the behavior of the `#` modifier (alternative mode) together with `ll` (long long modifier), and specifically exposing the example format string mentioned in bug #114.
* Our fix for #109 was too eager to keep `FLAG_HASH` - it dropped it only when a precision wasn't specified. We're now going part of the way back - dropping `FLAG_HASH` even when precision wasn't specific - except for octal.
* The `long long` version of ntoa now behaves just like the `long` version.
eyalroz pushed a commit to eyalroz/printf that referenced this issue Aug 3, 2021
@eyalroz
Exposing bugs mpaland#75, mpaland#99, mpaland#109, mpaland#110 via th…
45a85d7 
…e test suite.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 3, 2021
@eyalroz
Fixes mpaland#109, mpaland#110: Now properly handling the leading 0 i…
6a3ad44 
…n the octal format.
eyalroz referenced this issue in eyalroz/printf Aug 3, 2021
@eyalroz
Fixes #114; regards #109, #99, #110.
64e2b3e 
* Added a couple of test cases for exposing the behavior of the `#` modifier (alternative mode) together with `ll` (long long modifier), and specifically exposing the example format string mentioned in bug #114.
* Our fix for #109 was too eager to keep `FLAG_HASH` - it dropped it only when a precision wasn't specified. We're now going part of the way back - dropping `FLAG_HASH` even when precision wasn't specific - except for octal.
* The `long long` version of ntoa now behaves just like the `long` version.
KarlK90 pushed a commit to qmk/printf that referenced this issue Jul 7, 2022
@eyalroz
Fixes mpaland#110 + other test suite changes:
4b0a54c 
* Split the "float" testcase into several cases regarding float-point specifiers.
* Renamed "types" -> "integer types
* Added a few testcases with non-numeric floating-point values and the `E` specifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz