Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width specifier not always respected for non-left-aligned fields #113

Open
eyalroz opened this issue Jul 30, 2021 · 0 comments
Open

Width specifier not always respected for non-left-aligned fields #113

eyalroz opened this issue Jul 30, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Jul 30, 2021 •
edited
Loading

If we run sprintf_("%-20.5i", 123), we get 123 + 17 spaces rather than 00123 + 15 spaces.

This bug was noticed and supposedly fixed in this commit of mickjc750's fork.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#113 : Now properly zero-padding left-aligned values wit…
8f9f51c 
…h precision set.

Also, added a relevant test suite check.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
A dummy merge indicating the repository has already adapted the bug f…
a26f36a 
…ix in @mickjc750's `bugfix` branch (for mpaland#113).
@eyalroz eyalroz changed the title Width specifier not always respected Width specifier not always respected for non-left-aligned fields Jul 30, 2021
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#113 : Now properly zero-padding left-aligned values wit…
d21a47e 
…h precision set.

Also, added a relevant test suite check.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
@eyalroz
Fixes mpaland#113 : Now properly zero-padding left-aligned values wit…
438fb76 
…h precision set.

Also, added a relevant test suite check.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 3, 2021
@eyalroz
Fixes mpaland#113 : Now properly zero-padding left-aligned values wit…
d303ed3 
…h precision set.

Also, added a relevant test suite check.
KarlK90 pushed a commit to qmk/printf that referenced this issue Jul 7, 2022
@eyalroz
Fixes mpaland#113: Making the number of Taylor series terms we use fo…
99aeb57 
…r `log10()` approximation controllable by a CMake option, and changed the default from 2 to 4 (which is the maximum supported at the moment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz