Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batchSize without having to configure ajaxAppender #82

Open
drmorale opened this issue Oct 28, 2015 · 3 comments
Open

batchSize without having to configure ajaxAppender #82

drmorale opened this issue Oct 28, 2015 · 3 comments

Comments

@drmorale
Copy link

We would like to be able to configure batchSize without having to add an ajaxAppender xml node (ie onto the default appender).

@mperdeck
Copy link
Owner

Thanks for your suggestion. I would agree it would be nice to have this, so I've marked it as an enhancement. However, to me it doesn't have high priority.

@drmorale
Copy link
Author

drmorale commented Nov 5, 2015

I'll take care of it! Let me know if there's a direction you can point me in!

@mperdeck
Copy link
Owner

mperdeck commented Nov 6, 2015

I guess you're after a syntax like this:

To be honest, I'm a bit dubious about this:

  1. I'm not sure about the business value. I would agree that it is a bit of a pain to have to create a new appender if you want a non-default batchSize or Url, or whatever, but it is not that hard (create appender, assign to root logger so all loggers pick it up).


  1. It is a relatively big change, in that when you define an appender, in the current implementation you actually create a new appender, while you want to modify an existing appender.

Big change = big risk. Plus backwards compatibility is really very important to me.

However, I do have an open mind on this. If you find a low risk way of implementing this feature, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants