-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some videos stutters ever since mpv-x86_64-20240820-git-67e087d release #14806
Comments
Can you provide logs with FWIW
Though I don't see what could cause this in that regression range. edit: There are some ffmpeg hevc refactors in that regression range, can you reproduce with any other codec? |
It is a HEVC specific bug. I think it has something to do with one of the encoding settings, which there are plenty of if you take a look at the sample OP linked.
|
I can reproduce the stutter with ffplay from master, I'll bisect what caused it |
Caused by FFmpeg/FFmpeg@2fdecbb |
I have this exact same issue since the very same version. I was going to post but I found this before I posted luckily. I'm still running the one for windows v3 version from 2004-08-17 for that reason. I have a Terminator 2 clip that makes it easy to reproduce. If i hit forward arrow on keyboard to skip ahead it will stutter non stop. Today's release still has the issue. |
Please report to https://trac.ffmpeg.org. I reported on IRC but it doesn't seem trivial to diagnose why it happens so it might get forgotten. |
pkt_dts needs to be set manually when using the receive_frame() callback, so it was unset after 2fdecbb. Fixes PTS guessing for certain files with broken timestamps. Cf. mpv-player/mpv#14806 Reported-by: llyyr <[email protected]>
Fixed upstream |
Fixed by: FFmpeg/FFmpeg@b538006 |
pkt_dts needs to be set manually when using the receive_frame() callback, so it was unset after 2fdecbb239714b6203e37067fda2521f80e19d47. Fixes PTS guessing for certain files with broken timestamps. Cf. mpv-player/mpv#14806 Reported-by: llyyr <[email protected]> Signed-off-by: Paul B Mahol <[email protected]>
I noticed this commit. I doubt it wasn't fixed clearly. |
Are you sure it's the same issue? Would be helpful if you could bisect since the issue should be reproducible with ffplay as well. |
Does ffplay have the option like |
The issue linked in this ticket only happens on certain (broken) files that ffmpeg manages to playback correctly with PTS guessing. If your issue happens with all hevc files, or only when seeking, or only with hwdec, then it's a different issue. |
It's not the same issue but probably another regression caused by the refactor. I can share sample. |
Can't reproduce here with hwdec_vaapi or hwdec_vulkan. I'm not saying it's impossible for a regression to only affect d3d11va, but I can't report this upstream myself. I'd recommend bisecting ffmpeg and making sure it's the same commit that causes the regression, then reporting it on trac. |
Doesn't happen on my end.
That would be best idea. |
mpv Information
Other Information
Reproduction Steps
Tried all mpv version after mpv-x86_64-20240819-git-a3baf94 release, with and without config.
Expected Behavior
Video plays normally
Actual Behavior
Video stutters
Log File
mpv-x86_64-20240906-git-0eb5e91 (stutters)
log.txt
mpv-x86_64-20240819-git-a3baf94 (doesn't stutter)
log.txt
Sample Files
sample.mp4
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: