Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading statement about matrix multiplication and dot product #563

Open
0xdbff opened this issue Jun 21, 2023 · 2 comments
Open

Misleading statement about matrix multiplication and dot product #563

0xdbff opened this issue Jun 21, 2023 · 2 comments

Comments

@0xdbff
Copy link

0xdbff commented Jun 21, 2023

I've noticed a potentially misleading statement in notebook 00. The statement is: "Multiplying matrices by each other is also referred to as the dot product."

While it's true that matrix multiplication involves calculating a series of dot products, the two operations are not the same. The dot product is an operation between two vectors that results in a scalar, while matrix multiplication is an operation between two matrices that results in another matrix. In the context of TensorFlow, tf.matmul() performs matrix multiplication, and tf.tensordot() can perform a similar operation when the axes parameter is set to 1 https://www.tensorflow.org/api_docs/python/tf/tensordot . However, these are distinct operations and should not be conflated.

I believe this statement could lead to confusion, especially for those new to these concepts. I suggest it be revised for clarity. Using tf.tensordot() for matrix multiplication can be valid in certain contexts, but the key point here is the misleading conclusion drawn from the statement.

@JaynouOliver
Copy link

thanks, just went through that video 1 day ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants