Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light mode #54

Open
0-wiz-0 opened this issue Jan 12, 2024 · 9 comments
Open

light mode #54

0-wiz-0 opened this issue Jan 12, 2024 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jan 12, 2024

The colors by default seem to be for a white-on-black terminal - on a black-on-white one, the headers for entries are basically invisible.
The default generated config has light/dark mode settings, but I didn't see anything in README.md nor neonmodem --help to select light mode.
So is light mode already available? Please document it.
Thanks!

@mrusme mrusme added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 12, 2024
@mrusme
Copy link
Owner

mrusme commented Jan 12, 2024

It should be documented, correct. The way it works right now is that when you launch it first time it generates the config and hence sets the theme according to your current terminal. It uses lipgloss' AdaptiveColor feature for that. So in theory you could switch by deleting the config and launching it in a Terminal with white background/black text, to get the light theme.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 12, 2024

Hm, I only use black-on-white terminals but it seems it selected the dark theme - at least some lines were unreadable if the cursor was not on them.

@mrusme
Copy link
Owner

mrusme commented Jan 12, 2024

Would you mind to provide further details? Terminal, color scheme (ideally the config), neonmodem config (without credentials);

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 12, 2024

Sure.
Apple Terminal -> ssh -> tmux with TERM=screen-256color

Config file
Screenshot

@mrusme
Copy link
Owner

mrusme commented Jan 12, 2024

Thank you! I'm not super keen on downloading random zips from the internet, and I assume many people aren't. Since there should only be config files in that archive: Would you mind attaching them directly or, in case they're not super long, inlining them? Thank you very much!

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 12, 2024

I tried uploading the toml file, but the github file selector didn't allow that. So I zipped it up and that worked.
I now renamed it from neonmodem.toml to neonmodem.txt and that was allowed by github, so here it is:
neonmodem.txt

Oh, and yes, I set HOME=/tmp for this test, just in case you're wondering.

@mrusme
Copy link
Owner

mrusme commented Jan 12, 2024

The config seems okay, I will have to dig deeper and try it myself with a light config on Alacritty. However, if you're looking for a quick fix: You could change the values manually in the config file for each color that is hard to read and theme it to your taste. Try it with a could of existing values first and see if you get the desired results. Afterwards you can basically go crazy on customization if you desire to.

Note to myself: Talk to @meowgorithm to see if this format for theme configuration would be something that could be adapted universally and, if so, develop a dedicated theme editor TUI tool for editing the theme settings.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 12, 2024

Thanks for looking at this!
Editing this file will probably work, but I'll have to read all of it to guess which settings will affect which line, which stopped me from doing that so far.
Just one more question: there are 'Light' and 'Dark' lines for all of these - is there way to switch to using the 'Light' settings for all of them? (I guess now the 'Dark' ones are used.)

@mrusme
Copy link
Owner

mrusme commented Jan 13, 2024

@0-wiz-0 I can only tell what the lipgloss documentations says:

The terminal's background color will automatically be detected and the appropriate color will be chosen at runtime.

I haven't looked into it deep enough to see how detection works and how one could trigger the use of either color scheme. I suppose that using a black-on-white theme will trigger lipgloss to use the light theme. Maybe also give a different Terminal a try?

(disclaimer: Dark mode only user here :-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants