Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow illlegal trailing commas in order by clause #54

Open
tomharmon opened this issue Feb 3, 2020 · 0 comments
Open

Disallow illlegal trailing commas in order by clause #54

tomharmon opened this issue Feb 3, 2020 · 0 comments

Comments

@tomharmon
Copy link
Contributor

Currently on master:

order_expr: many0!(

In src/order.rs, the order by clause allows for trailing commas, which is technically invalid SQL.
Eg, "select * from users order by name ascage desc,\n" will parse, but should not

In the incoming bump nom to v5 PR, this is on line 76 of the same file:

76        many0(order_expr),
@tomharmon tomharmon mentioned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant