Calling LMap.zoomToContent() throws exception on client side if map is empty

[dominic-simplan]

Calling LMap.zoomToContent() while the map is empty causes JavaScript errors on the client side:

SEVERE: Error in resize listener
com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'invalidateSize' of undefined
SEVERE: (TypeError) : Cannot read property 'addControl' of undefined
com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'addControl' of undefined
SEVERE: (TypeError) : Cannot read property 'setZIndex' of undefined
com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'setZIndex' of undefined
SEVERE: (TypeError) : Cannot read property 'addLayer' of undefined
com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'addLayer' of undefined

The getContentBounds() method returns an empty GeometryCollection, which seems to lead to Bounds with an infinity southeast coordinate in the zoomToExtent method (and therefore probably fails on the client side?):

Bounds bounds = JTSUtil.getBounds(geometry);
zoomToExtent(bounds);

Possible solution might be to add an !contentBounds.isEmpty() check to the zoomToContent() method?

[mstahv]

I can't reproduce the issue. Are you using the latest version? If not, can you provide a minimalistic code example to reproduce the issue?

[octavm]

Here is some code to reproduce the issue:

LPolyline lPolyline = new LPolyline(new LineString(new CoordinateArraySequence(new Coordinate[]{}),
				new GeometryFactory(new PrecisionModel(PrecisionModel.FLOATING))));
leafletMap.addLayer(lPolyline);
leafletMap.zoomToContent();

The getContentBounds returns "LINESTRING EMPTY", the contentBounds!=null check passes, in method zoomToExtent(), JTSUtil.getBounds(geometry), returns Bounds{southWestLng=1.7976931348623157E308, southWestLat=1.7976931348623157E308, northEastLng=-Infinity, northEastLat=-Infinity}.

As you can see the Bounds have infinite coordinate for northEastLng, and nortEastLat.

Then program flows into zoomToExtent(Bounds) method where RpcProxy is called with infinite coordinate Bounds and fails on the client side.

As @dominic-simplan suggests, a possible solution in LMap can be:

if (contentBounds != null && !contentBounds.isEmpty()) {
    zoomToExtent(contentBounds);
}