Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash fixes #82

Merged
merged 1 commit into from
Apr 30, 2023
Merged

crash fixes #82

merged 1 commit into from
Apr 30, 2023

Conversation

imre84
Copy link
Contributor

@imre84 imre84 commented Apr 30, 2023

when you push the read button without selecting a mail first the mail mod crashes the full server. This pull request is supposed to fix that.

S-S-X
S-S-X approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge soon unless someone raises concerns or requests changes.
Seems like this also deserves tracking link to #70

@Athozus Athozus added this to the 1.1.4 milestone Apr 30, 2023
@Athozus Athozus added the Bug Something isn't working label Apr 30, 2023
@Athozus
Copy link
Member

Athozus commented Apr 30, 2023

I think that this function could also fix #80 and #81.

@S-S-X S-S-X merged commit ec92aab into mt-mods:master Apr 30, 2023
@Athozus Athozus mentioned this pull request May 1, 2023
Closed
@Athozus Athozus added the Good first issue Good for newcomers label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-S-X S-S-X S-S-X approved these changes

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Good first issue Good for newcomers
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@imre84 @Athozus @BuckarooBanzay @S-S-X