Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History is broken #3

Open
mtalexan opened this issue Jun 13, 2018 · 0 comments
Open

History is broken #3

mtalexan opened this issue Jun 13, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@mtalexan
Copy link
Owner

Duplicating from versionone#27

History of an asset is broken because v1meta.asset_from_oid does not take the moment into consideration when construction the asset. So oidtokens of form 'Story:1:2' ignore the moment portion of 2 and always return the latest Story(1).

The fix is to check for the moment in the oidtoken parameter and return the correct historical instance of the object if it is there. I do not yet know how to do this though.
@mtalexan mtalexan added the bug Something isn't working label Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtalexan