Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions API #102

Open
miceno opened this issue Jul 30, 2018 · 1 comment
Open

Improve exceptions API #102

miceno opened this issue Jul 30, 2018 · 1 comment

Comments

@miceno
Copy link

miceno commented Jul 30, 2018

I am using hdfscli with fastparquet to remotely read a parquet file over HDFS.

When it turns to be an exception, hdfscli rises a HdfsError generic exception.

I suggest it should add more specific classes like HdfsFileDoesNotExist inheriting from IOError, or the like. This way it will be easier to filter exceptions and integrating it with libraries that expect a file-like interface.

@mtth
Copy link
Owner

mtth commented Mar 31, 2019

Making it easier to tell apart exceptions (without looking at the message) sounds like a good idea. I'd be happy to review a PR which implements this.

@mtth mtth changed the title Make HdfsError class inherit from IOError or be more specific on exception classes Improve exceptions API Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants