Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env-template #2

Open
stubar opened this issue Nov 9, 2023 · 1 comment
Open

env-template #2

stubar opened this issue Nov 9, 2023 · 1 comment

Comments

@stubar
Copy link

stubar commented Nov 9, 2023

Hi thanks for making a great app!

During following the setup part of the app I was struggling to know what the env var names were. I ended up grepping for getenv to find them out. I have since realised they were in the section above doh!. Anyhow I was thinking of creating a .env-template and adding to the readme. Happy to raise a PR.

Also when searching for the env var I noticed some SMTP details, as this is a financial tool with access to sensitive stuff it did initially ring 'phone home' alarm bells for me. I see now it looks all innocent, perhaps some future feature for notifying of errors? Anyhow I think something in the readme would help here as well.
@willbeeching
Copy link
Contributor

Added this in the PR ce4c851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stubar @willbeeching