-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tooling. #15
Comments
Thanks for the suggestion @alejandronanez. Actually, I was planning to setup Travis CI for now. And I'm always welcome to contributions. Send a PR. |
Sounds good!
Will do then!
…On Thu, May 25, 2017 at 6:11 AM Mubaris NK ***@***.***> wrote:
Thanks for the suggestion @alejandronanez
<https://github.com/alejandronanez>. Actually, I was planning to setup
Travis CI for now. And I'm always welcome to contributions. Send a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcYUjyKsu_O4Y8gsodmZf5N7guyy8ofks5r9WHFgaJpZM4Nlqp->
.
|
@alejandronanez Maybe you wanna checkout coala to combine ESlint & csslint. If you're working on it, make a new branch for it. Then send PR. 😄 |
Cool! Will check that out!
…On Thu, May 25, 2017 at 8:32 AM Mubaris NK ***@***.***> wrote:
@alejandronanez <https://github.com/alejandronanez> Maybe you wanna
checkout coala <https://github.com/coala/coala> to combine *ESlint* &
*csslint*.
If you're working on it, make a new branch for it. Then send PR. 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcYUvsWJ_P1zFr7F112KaVQjkK7638Vks5r9YLhgaJpZM4Nlqp->
.
|
Is it possible that some of those new tooling changed some varibables (var or let keyword) to constants (const keyword) ? For example: const projectsPerPage at main.js can't be modified from languageSelector.js (It was a var projectsPerPage at previous commit). I'm fixing it for isse #18 but I'm afraid it would happen again. This is another problem of the current lack of modularization (see issue #17 ) |
I'm working on #17 , I think I will use If you declare varibles on the top, it won't be an issue. I think that's okay. Then you can declare |
I think the change from var->const was possible. And yes that's a problem of having globals leaking all over the place. Maybe a quick search/replace to fix this in the short term. :( |
What about adding some eslint / prettier / .editorconfig or maybe some build system?
I'll be down for helping with some of those.
Thanks!
And great project BTW
The text was updated successfully, but these errors were encountered: