Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tooling. #15

Closed
alejandronanez opened this issue May 24, 2017 · 7 comments
Closed

Add some tooling. #15

alejandronanez opened this issue May 24, 2017 · 7 comments

Comments

@alejandronanez
Copy link
Contributor

What about adding some eslint / prettier / .editorconfig or maybe some build system?

I'll be down for helping with some of those.

Thanks!

And great project BTW

@mubaris
Copy link
Owner

mubaris commented May 25, 2017

Thanks for the suggestion @alejandronanez. Actually, I was planning to setup Travis CI for now. And I'm always welcome to contributions. Send a PR.

@alejandronanez
Copy link
Contributor Author

alejandronanez commented May 25, 2017 via email

@mubaris
Copy link
Owner

mubaris commented May 25, 2017

@alejandronanez Maybe you wanna checkout coala to combine ESlint & csslint.

If you're working on it, make a new branch for it. Then send PR. 😄

@alejandronanez
Copy link
Contributor Author

alejandronanez commented May 25, 2017 via email

@raulvillares
Copy link
Contributor

Is it possible that some of those new tooling changed some varibables (var or let keyword) to constants (const keyword) ?

For example: const projectsPerPage at main.js can't be modified from languageSelector.js (It was a var projectsPerPage at previous commit). I'm fixing it for isse #18 but I'm afraid it would happen again.

This is another problem of the current lack of modularization (see issue #17 )

@mubaris
Copy link
Owner

mubaris commented May 26, 2017

I'm working on #17 , I think I will use webpack

If you declare varibles on the top, it won't be an issue. I think that's okay. Then you can declare var. If you want to declare var in the middle of other code, use "no-var": "off" in .eslintrc.json

@alejandronanez
Copy link
Contributor Author

I think the change from var->const was possible. And yes that's a problem of having globals leaking all over the place. Maybe a quick search/replace to fix this in the short term. :(

@mubaris mubaris closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants