Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLINT errors down to zero! #43

Open
1 task
alejandronanez opened this issue Jun 5, 2017 · 11 comments
Open
1 task

ESLINT errors down to zero! #43

alejandronanez opened this issue Jun 5, 2017 · 11 comments

Comments

@alejandronanez
Copy link
Contributor

alejandronanez commented Jun 5, 2017

We can do this gradually!

Pre requisites.

@mubaris
Copy link
Owner

mubaris commented Jun 5, 2017

Yeah, it should be done.

@alejandronanez
Copy link
Contributor Author

I think it would be nice to get rid of aaaaall the eslint errors (I think we have a TON). But doing that in one PR maybe too much. I'm ok if we do this gradually, one PR per file or something like that!

For this to be a thing, we need #17 to be merged in V2 first. BTW

@mubaris
Copy link
Owner

mubaris commented Jun 5, 2017

@alejandronanez Since I'm having some issues, #17 might take more time to finish. I'll try to send a PR as soon as I can.

@alejandronanez
Copy link
Contributor Author

@mubaris yeah don't feel rushed about it. I just had this on my mind and wanna make sure I don't forget!

@mubaris
Copy link
Owner

mubaris commented Jun 5, 2017

Cool

@jearl4
Copy link
Contributor

jearl4 commented Oct 5, 2017

Hope y'all don't mind if I ran eslint and cleaned up a few of the errors. Have a PR out there with the changes and will start work on the emoji file later.

@Suneet-M
Copy link

Are all the errors resolved? Or can I contribute as well?

@paulopacitti
Copy link

is this issue still open? Can I contribute?

@devcer
Copy link

devcer commented Oct 1, 2020

I would like to work on this. Can you assign this to me?

@mehargiri
Copy link

Is this issue still open? I want to contribute, can you assign this to me?

@ASP124
Copy link

ASP124 commented Oct 18, 2023

Hello, Is this issue still open to be resolved or can it be assigned to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants