-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLINT errors down to zero! #43
Comments
Yeah, it should be done. |
I think it would be nice to get rid of aaaaall the eslint errors (I think we have a TON). But doing that in one PR maybe too much. I'm ok if we do this gradually, one PR per file or something like that! For this to be a thing, we need #17 to be merged in |
@alejandronanez Since I'm having some issues, #17 might take more time to finish. I'll try to send a PR as soon as I can. |
@mubaris yeah don't feel rushed about it. I just had this on my mind and wanna make sure I don't forget! |
Cool |
Hope y'all don't mind if I ran eslint and cleaned up a few of the errors. Have a PR out there with the changes and will start work on the emoji file later. |
Are all the errors resolved? Or can I contribute as well? |
is this issue still open? Can I contribute? |
I would like to work on this. Can you assign this to me? |
Is this issue still open? I want to contribute, can you assign this to me? |
Hello, Is this issue still open to be resolved or can it be assigned to me? |
We can do this gradually!
Pre requisites.
The text was updated successfully, but these errors were encountered: