Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release download (windows and others?) missing .zip extension #49

Open
nathan-at-mulesoft opened this issue Sep 28, 2022 · 5 comments
Open

Comments

@nathan-at-mulesoft
Copy link

Describe the bug
The manual downloads have downloaded files with no extension. e.g. on windows that come out as dw-X.Y.Z-Windows - should have a .zip at the end.

To Reproduce
Go to the downloads for releases: https://github.com/mulesoft-labs/data-weave-cli/releases
Download the windows one, it'll save as dw-1.0.24-Windows
The source files however have their extensions when downloaded, so they are ok.

Expected behavior
Should have a .zip at the end so people can fire up the unzip tool/know what the format is of the file (on linux/mac it might be ambiguous what the file is, whether it should be executed as is.. on windows people might think they need to add a .exe or something).

Desktop:

  • OS: windows 11
  • Browser: chrome
  • Version: 105.0.5195.127 (Official Build) (64-bit)
@afelisatti
Copy link

Thanks for bringing this up, @nathan-at-mulesoft. We will take a look. Eventually, we would like to understand the package managers of the different environments and be able to do what we've done with Homebrew/Mac so this isn't a problem at all. If you have any insights around Windows on that it would be helpful.

@omkarium
Copy link

Yes. The Windows binary bundle is not a zip. You need to convert that to zip and then extract. But I am also facing issue with the linux binary. It says, "glibc_2.0 not found" while running on Latest version on Mint. Looks like the linux build is linked on an old machine.

@manikmagar
Copy link
Contributor

@afelisatti #72 could help streamline the artifact distribution.

@machaval
Copy link
Contributor

machaval commented Feb 1, 2023

@omkarium The build is being done on ubuntu latest on the github infrastructure. You can always try to build it your self it should be super simple and validate if that fix the problem. If so we can see what we can do.

@manikmagar
Copy link
Contributor

Yes. The Windows binary bundle is not a zip. You need to convert that to zip and then extract. But I am also facing issue with the linux binary. It says, "glibc_2.0 not found" while running on Latest version on Mint. Looks like the linux build is linked on an old machine.

@omkarium The WSL on windows seems to be running Ubuntu 18.04, while Ubuntu on GitHub Actions is using Ubuntu 22.04. Maybe that is causing the difference. Try updating WSL to use Ubuntu 22.04. If that works, maybe the CLI can be built on lower Ubuntu's like 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants