Dependency on github.com/blakeembrey/router#router-engine

[cdierkens]

This dependency blocks the ability to run in a CI/CD build, as a github style URLs attempt to git clone a dependency, instead of pulling from an NPM registry.

We have a closed environment that only has access to NPM packages through an Artifactory NPM registry.

The registry caches npmjs registry for anything not found in the private registry.
Any package can be published to the private registry.
Hitting URLs outside of the internal registry is not allowed.

[warroyo]

@blakeembrey any chance this can be updated I have the same issue mentioned above.

[blakeembrey]

I no longer work at MuleSoft and do not have access. I won't be able to help, sorry.

[sichvoge]

@cdierkens @warroyo Sorry for my stupidity, but what do you want us to do here?

[warroyo]

@sichvoge in this line https://github.com/mulesoft-labs/osprey-router/blob/master/package.json#L36 the dependency is directly referencing github, so instead of going to npm to get the package it is trying to clone. This causes a problem when you do not have access to the internet and you use something like artifactory to proxy packages. We are suggesting that the above line be changed to use npm instead. for example:

"router":"^1.3.1"

[cdierkens]

Blakes fork isn't published to npm, so you'll need to fork his changes and publish under a scope, something like @mulesoft/router.

…

On Thu, Jul 6, 2017 at 9:27 AM Will Arroyo ***@***.***> wrote: @sichvoge <https://github.com/sichvoge> in this line https://github.com/mulesoft-labs/osprey-router/blob/master/package.json#L36 the dependency is directly referencing github, so instead of going to npm to get the package it is trying to clone. This causes a problem when you do not have access to the internet and you use something like artifactory to proxy packages. We are suggesting that the above line be changed to use npm instead. for example: "router":"^1.3.1" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEluecfuHdf7bXbimt7GOIoSwinQJsW0ks5sLPzKgaJpZM4NubBf> .

[warroyo]

@cdierkens so in the readme https://github.com/blakeembrey/router/blob/master/README.md, under installation, this is just left over from the fork?

[cdierkens]

In github you can compare forks against the origin, although I'm sure the diff is huge and hard to comb through.

…

On Thu, Jul 6, 2017 at 9:31 AM Will Arroyo ***@***.***> wrote: @cdierkens <https://github.com/cdierkens> so in the readme https://github.com/blakeembrey/router/blob/master/README.md, under installation, this is just left over from the fork? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEluec-1zMq9sOhORwIbzS2m6n99lXCGks5sLP3kgaJpZM4NubBf> .

[blakeembrey]

The diff should be pretty straightforward. It's really just two PRs in a commit: blakeembrey/router@cfe18f9. Both are open PRs, one has been merged but the other is still a bit undecided: pillarjs/router#30 and pillarjs/router#29. Getting the path functionality plugin-able is the one still open, but I can re-submit a cleaner PR that implements the same functionality again and land that in the PillarJS router sooner so we can have an official release. /cc @dougwilson, are you ok with that?

[fedotov]

I see quite big difference between https://github.com/blakeembrey/router/ and https://github.com/pillarjs/router
And osprey-router a bit extends blakeembrey/router.
So why not include blakeembrey/router/ into osprey-router? Will that breach npm policy?

[cdierkens]

FWIW: This is still an issue, except you are pointing to an internal package. Why you don't just publish an npm package is beyond me.

Closing because this is beyond stale.