Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable switch to control publicness of workspaces #185

Open
waxlamp opened this issue Aug 17, 2021 · 5 comments
Open

Enable switch to control publicness of workspaces #185

waxlamp opened this issue Aug 17, 2021 · 5 comments

Comments

@waxlamp
Copy link
Contributor

waxlamp commented Aug 17, 2021

There should be a switch on workspaces to control whether they're public.

Upon creation of a workspace there should be a similar switch to control publicness from the start.

@JackWilb
Copy link
Member

This exists in the permissions dialog, but maybe you were thinking of making it more visible. Here's a screenshot showing it in the dialog:
image

@waxlamp
Copy link
Contributor Author

waxlamp commented Aug 30, 2021

In that screenshot, the text label bothers me. You don't click the checkbox to "make" the workspace public--the checkbox is synonymous with the workspace's publicness. I think a vuetify switch is more appropriate, and the label should say simply "Public". Need help from @jtomeck to get this right.

My issue filing was more about the lack of a switch when a workspace is created. There should be an option to make the workspace public ab ovo.

@jtomeck
Copy link
Contributor

jtomeck commented Aug 30, 2021

You don't click the checkbox to "make" the workspace public--the checkbox is synonymous with the workspace's publicness.

What is the difference between these two statements? Are you just saying you prefer a simpler label? If so I think I agree. Sorry jack, I think you pulled this directly from a design of mine iirc. I do think a switch that just says public will be less intrusive than the more wordy approach.

@waxlamp
Copy link
Contributor Author

waxlamp commented Aug 31, 2021

You don't click the checkbox to "make" the workspace public--the checkbox is synonymous with the workspace's publicness.

What is the difference between these two statements? Are you just saying you prefer a simpler label? If so I think I agree. Sorry jack, I think you pulled this directly from a design of mine iirc. I do think a switch that just says public will be less intrusive than the more wordy approach.

Mainly I am saying I prefer a simpler label, and for some reason that I have trouble expressing, the switch makes more sense here than a checkbox. It's all rather subtle.

Since you asked, there is a very slight difference between the two statements. The existing one feels heavier, like by clicking that checkbox, you're teeing up something big to happen when clicking "save". The simpler label just feels like you're flipping a light switch--changing the switch state changes the light state, so to speak. Again--it's very subtle, and I'm likely overthinking it.

But in the end, I think that "simpler is better" is the correct argument here, rather than my convoluted thinking about the two statements.

@jtomeck
Copy link
Contributor

jtomeck commented Aug 31, 2021

Since you asked, there is a very slight difference between the two statements. The existing one feels heavier, like by clicking that checkbox, you're teeing up something big to happen when clicking "save". The simpler label just feels like you're flipping a light switch--changing the switch state changes the light state, so to speak. Again--it's very subtle, and I'm likely overthinking it.

Thanks for clarifying. I didn't think that deeply about it, but I get it now. It is definitely subtle, but I agree with you about the change. Even though they do the same thing, the wording does make it feel like a bigger impact "control" than it is or should be. I appreciate this, because I think I would benefit from adopting this logic for a lot more of my UX decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants