Overhaul the testing system #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a later 3.x version for jest to work properly with ts-jest, but it turns out the 4.x series does not have any MAJOR breaking changes, so we're good to just upgrade to it.
jjnesbitt
approved these changes
May 10, 2021
There was a problem hiding this comment.
This looks fine to me and the tests pass, so I'm preemptively approving. However, I think we should file an issue to add back in the remaining tests, linking the current file, so we can easily see the full lists of tests.
See #35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rips out the
tapetesting infrastructure (RIP) and replaces it with a typescript-enabled Jest stack.The tests we used to run won't really work because the Multinet API now requires someone to be logged in before they can begin creating workspaces, etc. So I will first shift the library to work with the new API, then add OAuth support, then (likely) API key support, and then finally re-add the old tests.
Depends on #30.