Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more fields and fixed the Players field #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BonzaiThePenguin
Copy link

Added fields for Developer, Publisher, Date, Genre, and ESRB, and fixed the value for the Players field in a few cases. This data was populated from the following tables on Wikipedia, so we may need to add attribution?

http://en.wikipedia.org/wiki/Chronology_of_Nintendo_64_games
http://en.wikipedia.org/wiki/List_of_Nintendo_64_games

Added fields for Developer, Publisher, Date, Genre, and ESRB, and fixed the value for the Players field in a few cases. This data was populated from the following tables on Wikipedia, so we may need to add attribution?

http://en.wikipedia.org/wiki/Chronology_of_Nintendo_64_games
http://en.wikipedia.org/wiki/List_of_Nintendo_64_games
@BonzaiThePenguin
Copy link
Author

Warning: just noticed that this currently conflicts with rom.c's sanity checks. It's hard-coded to only accept GoodName, CRC, RefMD5, SaveType, Status, Players, Rumble, CountPerOp, and Cheat.

@Narann
Copy link
Member

Narann commented Mar 15, 2015

Great work! Thanks!

If you don't mind, I would let others discuss about those additions (Sanity checks you just pointed!).

For example. IIRC, developer is an information already write into the ROM's header, do we need to put this infor in this ini file?

@BonzaiThePenguin
Copy link
Author

I don't think the developer is included in the header. I checked beforehand to make sure, and "Rare" did not appear in any of the Rare games I have. It only has the name of the game.

(On a related note, the "release date" field from the N64 header documentation that's floating around online is probably mislabeled. I wrote down the values for the games in my library and three of the four bytes were identical across all of them, and the fourth one didn't seem to have any relation to a release date or a release order.)

rom.c would definitely have to be updated before any changes should be accepted, as right now it logs a ton of warnings to logcat about unrecognized fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants