Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: same ID for lat/long input fields #34

Open
biranit opened this issue Dec 30, 2015 · 0 comments
Open

Bug: same ID for lat/long input fields #34

biranit opened this issue Dec 30, 2015 · 0 comments

Comments

@biranit
Copy link

biranit commented Dec 30, 2015

Hi,

Really love this class - however, there is a small bug: when split_values=true, the two input (hidden) fields created for latitude and longitude receive the exact same ID. This is not allowed in HTML - but worse, it prevents using these fields for various additional JavaScript validations, extrapolations, etc.

I solved this by editing cmb-field-map.php and adding 'id' => $field->args( 'id' ) . '_longitude' (for example) to the $field_type_object->input array... so it's a simple fix...

Thanks,

Bira

@biranit biranit changed the title must have unique ID for input fields Bug: same ID for lat/long input fields Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant