Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused MCK pin setting #62

Open
jdthorpe opened this issue Oct 21, 2022 · 1 comment
Open

Unused MCK pin setting #62

jdthorpe opened this issue Oct 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jdthorpe
Copy link

This line means that the mck/sck pin is unset even when the user selects an MCK pin in the Driver Plugin UI. (at least for DACs that don't override the get_i2s)pins() method from base_driver.be). I would either drop if from the UI, set to a select_field with just one option ("0", "Unused", or "GND") or allow the user's selection to be passed through the DAC's configuration by default.

In my case, that I connected my DAC and and the result of the undefined / floating voltage on the MCK pin gave me infuriating pops / clicks for the first couple weeks until I discovered that the MCK pin on the DAC should just be connected to ground. This is pretty confusing and probably leads some new users to (incorrectly!) assume that this project isn't great.

@feelfreelinux
Copy link
Member

Good point. MCLK does have to actually be routed in DACs. This is actually a bug, as it should be reflected by default in the i2s mclk_io setting.

@feelfreelinux feelfreelinux added the bug Something isn't working label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants