Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #99

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Allow Symfony 7 #99

merged 1 commit into from
Dec 10, 2023

Conversation

peter17
Copy link
Contributor

@peter17 peter17 commented Dec 4, 2023

Thanks!

@mvdbos
Copy link
Owner

mvdbos commented Dec 4, 2023

@peter17 Thanks for taking the time to make a PR! Unfortunately, the build is failing. Could you have a look and perhaps update your PR?

@peter17
Copy link
Contributor Author

peter17 commented Dec 4, 2023

@mvdbos Sure! It seems it is linked to the signature of vendor/pdepend/pdepend/src/main/php/PDepend/DependencyInjection/Configuration.php::getConfigTreeBuilder
I updated this dependency as well to be compatible...

@mvdbos
Copy link
Owner

mvdbos commented Dec 6, 2023

@peter17 It still fails. Can you try again and test locally first with bin/static-analysis and bin/coverage-enforce 100 scripts? If that succeeds, it should be fine. Note that it only fails on PHP 8.2 and not on 8.0 or 8.1.

@peter17
Copy link
Contributor Author

peter17 commented Dec 10, 2023

@mvdbos It fails because of pdepend/pdepend#695

Let's just wait for the next release, then I will update this PR!

@mvdbos
Copy link
Owner

mvdbos commented Dec 10, 2023 via email

@peter17
Copy link
Contributor Author

peter17 commented Dec 10, 2023

@mvdbos Should be good now! I ran bin/static-analysis and bin/coverage-enforce 100 locally with PHP 8.2.13, successfully.

@mvdbos mvdbos merged commit f614b5e into mvdbos:master Dec 10, 2023
3 checks passed
@mvdbos
Copy link
Owner

mvdbos commented Dec 10, 2023

Thanks @peter17

@mvdbos
Copy link
Owner

mvdbos commented Dec 10, 2023

@peter17 I tagged 0.7.2 so should be available on Packagist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants