Skip to content
This repository has been archived by the owner on Dec 12, 2019. It is now read-only.

Issue when people use double quotes for key #13

Open
rapidos opened this issue Jan 25, 2011 · 0 comments
Open

Issue when people use double quotes for key #13

rapidos opened this issue Jan 25, 2011 · 0 comments

Comments

@rapidos
Copy link

rapidos commented Jan 25, 2011

Hi guys,
I'd love to make a pull request but I have really no idea on how I am supposed to do that (I believe I should add some tests)

Anyway, I guess it would be faster to just leave my thoughts here.

I am working on a project where the developers use to write <%=t ("home.login") %> wich isn't detected by your regexp.

Here is the new one:

def i18n_lookup_pattern
  /\b(?:I18n\.t|I18n\.translate|t)(?:\s|\():?["|']([a-z0-9_]+.[a-z0-9_.]+)["|']\)?/
end

I just replaced the single quotes by ["|']

Hope this helps!

PS: If you are down to explain me the process to make a proper pull request I'd love to hear from you.

Julien

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant