Code Review Comments Luke Fanguna

[Luke-Fanguna]

For readability, I would add this in the connection.execute() parameter to show where it is being used. If it is a global variable, it would look like it is being used somewhere else.

PeakPeeps/src/api/peepcoins.py

Line 19 in c5e21b2

add_peepcoins_query = text(

[Luke-Fanguna]

It looks like when the queries need more variables, you change the format of the json to insert strings. For consistency, I would keep the same format. Whether it needs two or ten variables, I'd keep the same format to make it cleaner

PeakPeeps/src/api/coupons.py

Line 32 in c5e21b2

{

[Luke-Fanguna]

This function is really dense and the formatting is hard to follow. Have consistency in writing queries. I've noticed that other queries are in proper SQL format.

PeakPeeps/src/api/peepcoins.py

Line 47 in c5e21b2

query = text("SELECT valid FROM coupons WHERE id = :coupon_id")

[Luke-Fanguna]

Not the biggest fan of separating "query" and then redefining it after each query. It would be easier to read if they were put into the text() and reduce the redundancy.

PeakPeeps/src/api/peepcoins.py

Line 56 in c5e21b2

query = text(

[Luke-Fanguna]

This part seems like it is asking for too much. It takes in the 'Routes' object but only uses 'location'.

PeakPeeps/src/api/routes.py

Line 112 in c5e21b2

def report_route(route_to_report: Routes):

[Luke-Fanguna]

Could you make the queries more compact in terms of formatting. Very large function just for two queries. Also, I don't see a point to have PEEP_COINS_FROM_POSTING_REVIEW if it will be 5 every call.

PeakPeeps/src/api/reviews.py

Line 23 in c5e21b2

def post_add_review(review_to_add: Reviews):

[Luke-Fanguna]

Now I see the usage of the global variable. I'd say there is no harm is rewriting queries just to make it more readable.

PeakPeeps/src/api/reviews.py

Line 44 in c5e21b2

add_peepcoins_query,

[Luke-Fanguna]

Fix the indenting here to make it seem more uniform. Other queries look good.

PeakPeeps/src/api/users.py

Line 146 in c5e21b2

SELECT id

[Luke-Fanguna]

Majority of these queries are majorly indented. Not the biggest fan. I'd say to align it like the other ones.

PeakPeeps/src/api/routes.py

Line 31 in c5e21b2

INSERT INTO route (name, user_id, location,

[Luke-Fanguna]

I'd say that this query is quite large. You can potentially create different tables for organization.

https://github.com/n-shinde/PeakPeeps/blob/c5e21b2277ebdb75b013e12e53dcb69739189c4a/src/api/routes.py#L39C37-L39C37

[Luke-Fanguna]

If the admin.py file will not be used, you can just delete it.

[Luke-Fanguna]

Will this output always be "True" and "Reported"? If so, I don't see the use in having those variables.

PeakPeeps/src/api/routes.py

Line 125 in c5e21b2

status = "Reported"

[Luke-Fanguna]

Commit messages like 'done maybe???' and 'try test again' is too vague. not enough info from those commit messages.