Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of mainline-content-discovery has iroh version 0.13 as a dependency #19

Open
philrhc opened this issue Dec 2, 2024 · 3 comments

Comments

@philrhc
Copy link

philrhc commented Dec 2, 2024

seems that latest version of mainline-content-discovery is built with iroh version 0.13 which causes some issues when trying to update swarmie to the latest version

https://docs.rs/crate/iroh-mainline-content-discovery/latest/source/Cargo.lock#1485

@philrhc philrhc changed the title rerelease with version 0.28 of iroh latest version of mainline-content-discovery has iroh version 0.13 as a dependency Dec 2, 2024
@matheus23
Copy link
Contributor

We should probably try to not upload that lockfile to crates.io. Nevertheless, it shouldn't have an effect if you install the iroh-mainline-content-discovery crate.

The actual iroh versions it's using are specified in its workspace Cargo.toml, and they're version 0.28:

iroh-net = "0.28"
iroh-blobs = "0.28"
iroh-base = "0.28"

Can you tell us more about the exact error you're getting?

@philrhc
Copy link
Author

philrhc commented Dec 3, 2024

i don't think that it's been released since the change was made to update the version to 0.28.0, here is the cargo.toml of the crate:
https://docs.rs/crate/iroh-mainline-content-discovery/latest/source/Cargo.toml

i'm working to bring swarmie back to life - https://github.com/philrhc/swarmie/tree/from-sendme

error[E0308]: mismatched types
   --> src/main.rs:588:9
    |
588 |         content, 
    |         ^^^^^^^ expected `iroh_base::hash::HashAndFormat`, found `HashAndFormat`
    |
    = note: `HashAndFormat` and `iroh_base::hash::HashAndFormat` have similar names, but are actually distinct types
note: `HashAndFormat` is defined in crate `iroh_base`
   --> /home/pcummins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iroh-base-0.28.0/src/hash.rs:225:1
    |
225 | pub struct HashAndFormat {
    | ^^^^^^^^^^^^^^^^^^^^^^^^
note: `iroh_base::hash::HashAndFormat` is defined in crate `iroh_base`
   --> /home/pcummins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iroh-base-0.13.0/src/hash.rs:209:1
    |
209 | pub struct HashAndFormat {
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `iroh_base` are being used?

@matheus23
Copy link
Contributor

Right. Yeah it seems like we haven't made releases for mainline-content-discovery recently.
Thanks for letting us know!
We'll let you know when we do the next release. In the mean time you might be able to get stuff working with git dependencies or [patch.crates-io] annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants